This repository was archived by the owner on May 3, 2023. It is now read-only.
Fix dll issue #149
Closed
Fix dll issue #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready now. Anyone got a clean docker container(with python 3.7, this probably doesn't reproduce on 3.8 and higher) they can use to test the artifacts on? My windows machine is too old/slow to run Docker and I have the vs build tools installed on my regular env(so can't reproduce a failure), and I can't run Windows containers on my Mac. No rush on this though. Even if this is good, we should wait until 1.4 to merge this. |
|
superseded. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.